On Sat, Dec 06, 2014 at 05:52:21PM +0100, Lukasz Marek wrote:
> On 06.12.2014 15:59, Michael Niedermayer wrote:
> >On Fri, Dec 05, 2014 at 12:21:21AM +0100, Michael Niedermayer wrote:
> >>On Thu, Dec 04, 2014 at 12:50:49AM +0100, Lukasz Marek wrote:
> >>[...]
> >>
> >>>index 49c8b40..4148752 100644
> >>>--- a/libavcodec/options.c
> >>>+++ b/libavcodec/options.c
> >>>@@ -303,3 +303,176 @@ const AVClass *avcodec_get_subtitle_rect_class(void)
> >>> {
> >>> return &av_subtitle_rect_class;
> >>> }
> >>>+
> >>>+#define TEST
> >>>+#ifdef TEST
> >>
> >>this looks wrong
> >
> >i mean wrong due to duplicate main() in the application
>
> Yes, I know. It is a stray.
> I thought I've sent updated patch.
> Updated version is attached.
> > Makefile | 2 > options.c | 171 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 173 insertions(+) > 0696582c3f9349aac510ecee48f38b911842bb48 > 0001-lavc-options-add-test-for-avcodec_copy_context.patch > From 936a8bd30da1ff09dfca3917695aba1d24639612 Mon Sep 17 00:00:00 2001 > From: Lukasz Marek <lukasz.m.lu...@gmail.com> > Date: Thu, 4 Dec 2014 00:06:40 +0100 > Subject: [PATCH 1/2] lavc/options: add test for avcodec_copy_context > > This test doesn't cover every possible issue with this function. > It covers options management only. LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
