Thanks, Yea quoting wikipedia made me cringe too, I did check with the engineer at our network who checked what we use for satellite broadcast which starts at 0x33. Because of the nature of the patch I didn't feel like digging up the specs.
Zach On Nov 18, 2014 3:57 PM, "Michael Niedermayer" <michae...@gmx.at> wrote: > On Tue, Nov 18, 2014 at 01:56:21PM -0800, Zach Swena wrote: > > Sorry, I am new to using Git. I have a .patch file, but I am not sure > what > > the proper way to send it is. I am using GitHub for windows. Anyway, > the > > .patch file is attached. > > > > Zach > > > > > > > > On Tue, Nov 18, 2014 at 10:33 AM, Timothy Gu <timothyg...@gmail.com> > wrote: > > > > > Hi, > > > > > > On Tue, Nov 18, 2014 at 9:02 AM, Zach Swena <zcybercomput...@gmail.com > > > > > wrote: > > > > Hi, > > > > > > > > Here is a patch to allow FFmpeg to use PID ranges compatible with > ATSC > > > > television. I based the new minimum value on the PID ranges here > > > > <http://en.wikipedia.org/wiki/MPEG_transport_stream>on wikipedia. > This > > > > should be sufficient to allow the use of any standard PID used in > ATSC > > > > television. > > > > > > > > Zach > > > > > > > > As Attached: > > > > in mpegtsenc.c line > > > > > > > > 1441c1441 > > > > < { .i64 = 0x0100 }, 0x0100, 0x0f00, > AV_OPT_FLAG_ENCODING_PARAM }, > > > > --- > > > >> { .i64 = 0x0100 }, 0x0020, 0x0f00, AV_OPT_FLAG_ENCODING_PARAM > }, > > > > > > > > > > We only read Git unified patches. `git commit` and `git format-patch > -1` > > > > > > Timothy > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > mpegtsenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > eec00a02476529142a50aac8b0e2bbaf5780df8b > 0001-min-value-for-mpegts_start_pid-to-allow-ATSC-PIDs.patch > > From dcd75a7f912a0a7e14314e9c66a6f9cf67351934 Mon Sep 17 00:00:00 2001 > > From: dedicatedbroadcastsolutions <zcybercomput...@gmail.com> > > Date: Tue, 18 Nov 2014 13:43:07 -0800 > > Subject: [PATCH] min value for mpegts_start_pid to allow ATSC PIDs > > patch applied > > > > > > Here is a patch to allow FFmpeg to use PID ranges compatible with ATSC > > television. I based the new minimum value on the PID ranges on > > wikipedia. This should be sufficient to allow the use of any standard > > PID used in ATSC television. > > wikipedia is generally not a good choice for these things. > Whenever possible the actual specifications (or drafts) should be > checked > but either way its better to allow the user to choose lower pids if > thats what (s)he wants ... > > thanks > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > When the tyrant has disposed of foreign enemies by conquest or treaty, and > there is nothing more to fear from them, then he is always stirring up > some war or other, in order that the people may require a leader. -- Plato > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
