On Sat, Nov 15, 2014 at 09:02:56AM +0200, Mika Raento wrote: > On 15 November 2014 09:00, Mika Raento <mi...@iki.fi> wrote: > > > On 14 November 2014 21:51, Michael Niedermayer <michae...@gmx.at> wrote: > > > >> On Fri, Nov 14, 2014 at 07:12:34PM +0200, Mika Raento wrote: > >> > this would cause mfra to be ignored in files larger than 2G > >> > --- > >> > libavformat/mov.c | 22 ++++++++++++++-------- > >> > 1 file changed, 14 insertions(+), 8 deletions(-) > >> > >> why not just chage the type of ret to int64_t instead of adding a > >> second return variable ? > >> > > > > Done, with a comment on why that works. > > > > Thanks. > > > > Ah, I forgot the second reason: with a separate seek_ret I can keep the > return code and not overwrite it with the return value of seeking back. I > prefer the first version of the patch.
ok, applied the first version Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3 "Rare item" - "Common item with rare defect or maybe just a lie" "Professional" - "'Toy' made in china, not functional except as doorstop" "Experts will know" - "The seller hopes you are not an expert"
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
