Timothy and Michael, I will modify the code according to your comments, then re-submit it. Thanks. Rong Yan ------------------ The world has enough for everyone's need, but not enough for everyone's greed.
------------------ ???????? ------------------ ??????: "Timothy Gu";<timothyg...@gmail.com>; ????????: 2014??11??2??(??????) ????12:37 ??????: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>; ????: Re: [FFmpeg-devel] [patch 1/3]Fix bug for POWER LE:/libavcodec/ppc/me_cmp.c ?????? Hi, On Friday, October 31, 2014, Michael Niedermayer <michae...@gmx.at> wrote: > > Why do you keep sending patches which duplicate code? > > Maybe someone can translate this to a language you understand > better then english: This is an Chinese translation. Hope this helps. ????Michael?????????????????? > > Code duplication is not allowed ???????????????????????????????????????????????????????????????????? > > #if A > foo > this > bar > #else > foo > that > bar > #endif ??????foo??bar??????????????????????????????????????"foo"??????????????????foo???????????????????????? > > foo > #if A > this > #else > that > #endif > bar > ???????????????????????????????????????????????????? > > also the then remaining difference (this vs that) should be avoided > as well by using appropriate macros and inline functions ?????????????????????????????????????????????????????????? ???????????????? #ifdef HAVE_BIGENDIAN #define DIFFERENT_PART this #else #define DIFFERENT_PART that #endif ???????????????? foo DIFFERENT_PART bar > there is already some duplicated code in there, this was a mistake. ????FFmpeg???????????????????????????????????????????????? > No more duplicated code should be added. ???????????????????????????? ?????????????????????????????????????????? Timothy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
