> On Oct 30, 2014, at 07:48, wm4 <nfx...@googlemail.com> wrote: > ... > The option name is a bit unspecific - how about "ignore_readorder"? > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
No objections here; new patch: >From 369cf0366a8d03f6a4b2d746ae420e42a18fcb34 Mon Sep 17 00:00:00 2001 From: Rodger Combs <rodger.co...@gmail.com> Date: Thu, 30 Oct 2014 04:33:17 -0500 Subject: [PATCH] avformat/assenc: Ass ignore_readorder option --- libavformat/assenc.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 8225967..bde1096 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -23,6 +23,8 @@ #include "avformat.h" #include "internal.h" +#include "libavutil/opt.h" + typedef struct DialogueLine { int readorder; char *line; @@ -30,12 +32,14 @@ typedef struct DialogueLine { } DialogueLine; typedef struct ASSContext{ + const AVClass *class; int write_ts; // 0: ssa (timing in payload), 1: ass (matroska like) int expected_readorder; DialogueLine *dialogue_cache; DialogueLine *last_added_dialogue; int cache_size; int ssa_mode; + int ignore_readorder; }ASSContext; static int write_header(AVFormatContext *s) @@ -178,7 +182,7 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt) return AVERROR(ENOMEM); } insert_dialogue(ass, dialogue); - purge_dialogues(s, 0); + purge_dialogues(s, ass->ignore_readorder); } else { avio_write(s->pb, pkt->data, pkt->size); } @@ -192,6 +196,20 @@ static int write_trailer(AVFormatContext *s) return 0; } +#define OFFSET(x) offsetof(ASSContext, x) +#define E AV_OPT_FLAG_ENCODING_PARAM +static const AVOption options[] = { + { "ignore_readorder", "write events immediately, even if they're out-of-order", OFFSET(ignore_readorder), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 1, E }, + { NULL }, +}; + +static const AVClass ass_class = { + .class_name = "ass muxer", + .item_name = av_default_item_name, + .option = options, + .version = LIBAVUTIL_VERSION_INT, +}; + AVOutputFormat ff_ass_muxer = { .name = "ass", .long_name = NULL_IF_CONFIG_SMALL("SSA (SubStation Alpha) subtitle"), @@ -203,4 +221,5 @@ AVOutputFormat ff_ass_muxer = { .write_packet = write_packet, .write_trailer = write_trailer, .flags = AVFMT_GLOBALHEADER | AVFMT_NOTIMESTAMPS | AVFMT_TS_NONSTRICT, + .priv_class = &ass_class, }; -- 2.1.0.rc1.4.g764c739 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel