On Sat, Oct 18, 2014 at 03:47:38PM -0700, Nicholas Robbins wrote:
> > On Saturday, October 18, 2014 8:55 AM, Nicholas Robbins 
> > <nickrobbins-at-yahoo....@ffmpeg.org> wrote:
[...]
> @@ -66,6 +73,10 @@ static const AVOption perspective_options[] = {
>      { "interpolation", "set interpolation", OFFSET(interpolation), 
> AV_OPT_TYPE_INT, {.i64=LINEAR}, 0, 1, FLAGS, "interpolation" },
>      {      "linear", "", 0, AV_OPT_TYPE_CONST, {.i64=LINEAR}, 0, 0, FLAGS, 
> "interpolation" },
>      {       "cubic", "", 0, AV_OPT_TYPE_CONST, {.i64=CUBIC},  0, 0, FLAGS, 
> "interpolation" },
> +    { "sense",   "specify the sense of the coordinates", OFFSET(sense), 
> AV_OPT_TYPE_INT, {.i64=PERSPECTIVE_SENSE_SOURCE}, 0, 1, FLAGS, "sense"},
> +    CONST("source",       "specify locations in source to send to corners in 
> destination", PERSPECTIVE_SENSE_SOURCE,      "sense"),
> +    CONST("destination", "specify locations in destination to send corners 
> of source",    PERSPECTIVE_SENSE_DESTINATION, "sense"),

I think using macros here is a bad idea, it breaks "git grep" and
doesnt really make the code smuch shorter


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to