On Fri, Oct 10, 2014 at 01:10:58PM +0200, Benoit Fouet wrote:
> Hi,
>
> ----- Mail original -----
> > On Fri, Oct 10, 2014 at 10:28:51AM +0200, Benoit Fouet wrote:
> > > Hi,
> > >
>
> [...]
>
> > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > index bfee866..f592c9c 100644
> > > --- a/libavformat/movenc.c
> > > +++ b/libavformat/movenc.c
> > > @@ -31,6 +31,7 @@
> > > #include "avio.h"
> > > #include "isom.h"
> > > #include "avc.h"
> > > +#include "libavcodec/ac3_parser.h"
> > > #include "libavcodec/get_bits.h"
> > > #include "libavcodec/put_bits.h"
> > > #include "libavcodec/vc1_common.h"
> > > @@ -292,6 +293,182 @@ static int mov_write_ac3_tag(AVIOContext *pb,
> > > MOVTrack *track)
> > > return 11;
> > > }
> > >
> > > +struct eac3_info {
> > > + uint8_t ec3_done;
> > > +
> > > + /* Layout of the EC3SpecificBox */
> >
> > > + /* maximum bitrate */
> > > + uint16_t data_rate;
> > [...]
> > > + info->data_rate = FFMAX(info->data_rate, hdr->bit_rate);
> > [...]
> > > + put_bits(&pbc, 13, info->data_rate);
> >
> > something is wrong here, a bit_rate of 128000 (128k) wont fit in a
> > uint16_t nor in 13 bits
> >
>
> Yeah, this should be the bitrate in kbits/s, fixed, thanks.
>
> --
> Ben
> > isom.c | 1 > movenc.c | 190 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > movenc.h | 2 > 3 files changed, 193 insertions(+) > 8c7ccfbc3e0a52e9189185c6bb002d556c0d999e > 0001-avformat-movenc-add-EAC3-muxing-support.patch > From 410873578664479b5b236063cbc9421cc5eb0e54 Mon Sep 17 00:00:00 2001 > From: Benoit Fouet <benoit.fo...@free.fr> > Date: Tue, 7 Oct 2014 14:57:19 +0200 > Subject: [PATCH] avformat/movenc: add EAC3 muxing support. > > Support only one independent substream right now, and only syncframes > containing 6 blocks. > > Fixes part of ticket #3074 applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
