On Tue, Sep 23, 2014 at 11:32:08PM +0200, Reimar Döffinger wrote: > > > On 23.09.2014, at 02:27, Michael Niedermayer <michae...@gmx.at> wrote: > > > On Tue, Sep 23, 2014 at 01:01:26AM +0200, Reimar Döffinger wrote: > >> On Tue, Sep 23, 2014 at 12:42:53AM +0200, Michael Niedermayer wrote: > >>> Signed-off-by: Michael Niedermayer <michae...@gmx.at> > >>> > >> > >> Maybe more readable if you do reindentation separately? > > > > yes, will do > > > > > >> Because I was going to suggest to use elif until I saw that that part > >> is not actually used. > > > >> Also doesn't this patch also add --enable-sdl? Seems it will be ignored, > >> shouldn't we rather fail if --enable-sdl was given but we do not find > >> it? I believe that is how FFmpeg configure normally behaves. > > > > posted a seperate patch for that > > I _think_ they are all ok, but I did only a quick review and no testing.
applied the sdl patches thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
