Hi,
----- Mail original -----
> On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote:
> > Here is a patch to illustrate this...
>
> this looks better but:
>
>
> [...]
> > - ff_put_bmp_header(pb, enc, ff_codec_bmp_tags, 0,
> > 0);
> > + if (keep_height) {
> > + enc->extradata_size -= 9;
> > + if (!enc->extradata_size)
> > + av_freep(&enc->extradata);
> > + }
>
> what if extradata is stored in 2 files, the 2nd muxer would no longer
> see it
> also the muxer shouldnt change the encoders/demuxer extradata
>
> and cant all this logic be put in ff_put_bmp_header() ?
> might even be simpler
>
Do you mean that ff_put_bmp_header() would check for the BottomUp presence and
not negate height in this case, and also only write the palette in the stream?
--
Ben
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
