On Tue, 16 Sep 2014 21:37:08 +0200 Clément Bœsch <u...@pkh.me> wrote:
> On Sun, Sep 14, 2014 at 10:01:55AM +0200, Clément Bœsch wrote: > > After this the order from the original file is stored through readorder > > when doing ffmpeg -i input.ass -c copy output.mkv. > > > > And now that the ASS muxer honors the ReadOrder, extracting the ass back > > (without transcoding) restores the original order. > > > > TODO: micro bump? > > --- > > libavformat/assdec.c | 37 +++++++++++++++++++++++++++++++++---- > > 1 file changed, 33 insertions(+), 4 deletions(-) > > > > ping I can just say that it looks reasonable to me. One problem was whether ReadOrder starts with 0 or 1. The "spec" seems to imply it's 1 (never clearly stated, but an example uses 1), but all real world files use 0, and we concluded that it must be 0. One minor detail: could it be that the layer field has whitespace between the number and the ','? AFAIK strtol() doesn't skip trailing whitespace. It's also a bit annoying that the code looks at the event lines twice (read_ts and reformat_line). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
