On Mon, Sep 15, 2014 at 09:47:12AM +0200, Hendrik Leppkes wrote: > On Mon, Sep 15, 2014 at 3:16 AM, James Almer <jamr...@gmail.com> wrote: > > > On 14/09/14 9:38 PM, Michael Niedermayer wrote: > > > On Sun, Sep 14, 2014 at 08:47:11PM -0300, James Almer wrote: > > >> Signed-off-by: James Almer <jamr...@gmail.com> > > >> --- > > > > > > should be ok > > > > Pushed. Thanks. > > > > > > > > > > >> This should have been done before 2.4 was cut since the two files are > > pretty much > > >> bloat in the tar file now. > > > > > >> We can still cherry pick this for 2.4.1, though. > > > > > > removing a header is not ok in a point release, even if its a empty > > > header, it could break build of an application > > > > It's not an installed header, but i guess applications that compile ffmpeg > > straight > > from the tree could be potentially affected. > > > > > Applications that use private headers are doing so at their own risk, we > change those around without thinking about compat all the time.
yes, in git master, though even there changes to a private header that we know some applications used should be done with some thinking about compat > This shouldn't block anything. Just because theres a sign saysing "No tresspassing" still doesnt mean its a good idea to blindfoldedly fire a gun in the area for no good reason IMO point releases are about bugfixes, removing the header fixes no bug. It also adds no feature, its a source code cleanup and would reduce the source size by a few bytes So i dont see a good reason to make that change in a release branch This smells alot like "it might break some bad guys that misuse the API, lets go ahead and break em" <-- this is not a good reason [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
