On Fri, Sep 12, 2014 at 06:51:48PM +0200, Andreas Cadhalpun wrote: > Hi, > > On 12.09.2014 15:18, Michael Niedermayer wrote: > >On Fri, Sep 12, 2014 at 01:54:36PM +0200, Andreas Cadhalpun wrote: > >>On 11.08.2014 22:22, Michael Niedermayer wrote: > >>>On Mon, Aug 11, 2014 at 08:05:38PM +0200, Reimar Döffinger wrote: > >>>>Hello, > >>>>(sorry for being too lazy to send a patch) > >>>>With the major version bump AVProbeData was extended by a new field. > >>>>This so far has broken 3 places within FFmpeg and one within MPlayer, > >>>>where AVProbeData was only initialized field-by-field. > >>>>This will cause "random" crashes. > >>>>I'm at this point fairly certain a lot of other software will have the > >>>>same issue. > >> > >>That's for sure. > >> > >>>>I suggest we make add a big note with the release that everyone should > >>>>check their software for uses of AVProbeData that might result in parts > >>>>of that struct not being initialized. > >>> > >>>agree > >> > >>Please really document this! > > Attached 0001 patch adds documentation for this. > The 0002 patch changes the score to AVPROBE_SCORE_MIME for matching > mime types, which seems to have been intended [0].
patches 1 and 2 applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
