On Mon, Sep 8, 2014 at 5:21 PM, Michael Niedermayer <michae...@gmx.at> wrote: > On Mon, Sep 08, 2014 at 11:16:49AM -0700, hjiodjf 97xgw46 wrote: >> On Thu, Sep 4, 2014 at 1:08 PM, Michael Niedermayer <michae...@gmx.at> wrote: >> > On Tue, Sep 02, 2014 at 02:20:40PM -0700, hjiodjf 97xgw46 wrote: > [...] > >> Moreover, as you said, this patch reduces the number of passes through >> a blank frame from 4 to 2, which should improve performance on movies >> with many dark scenes. > > yes but thats seperate from what values are output for blank frames > > should be fixed so it only needs 2 passes now > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > When the tyrant has disposed of foreign enemies by conquest or treaty, and > there is nothing more to fear from them, then he is always stirring up > some war or other, in order that the people may require a leader. -- Plato > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
I was not aware that the cropdetect filter was designed to prevent shrinking the window over a given number of frames. I have attached a revised patch that prevents negative window sizes based on your patch. I still believe that negative windows should be avoided. My reasoning for this was provided in my previous email.
0001-Avoid-returning-negative-rectangles-from-cropdetect.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
