On 23/08/14 12:11 PM, Christophe Gisquet wrote: > Hi, > > 2014-08-23 16:52 GMT+02:00 James Almer <jamr...@gmail.com>: >>> -QPEL_TABLE 8, 8, b, sse4 >>> -QPEL_TABLE 10, 4, w, sse4 >>> -QPEL_TABLE 12, 4, w, sse4 >>> +QPEL_TABLE 8, 8, b, ssse3 >>> +QPEL_TABLE 10, 4, w, ssse3 >>> +QPEL_TABLE 12, 4, w, ssse3 >> >> Do these need to be duplicated? You could just remove the suffix and let >> every version of the function use the same tables. > > What do you mean by duplicated? That tables for 10 and 12 are? > > Otherwise, I'm leaving the ssse3/opt parameter for 2 reasons: > - try to not perform changes that aren't required for it to work > - I don't know how the avx2 code would look but indeed, if it had to > use other tables, it would then use new macro(s) > > Maybe your suggestions could be delayed after the code is converted to > ssse3? Probably there wouldn't be any, but patch conflicts would be > cumbersome.
I was talking about the opt suffix since both the ssse3 and sse4 tables will be the same. And sure, it was just a suggestion, so go with whatever is easier for you. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
