On 22/08/14 3:25 PM, Deb Mukherjee wrote:
> @@ -803,6 +807,11 @@ static const AVOption vp9_options[] = {
> { "tile-columns", "Number of tile columns to use, log2",
> OFFSET(tile_columns), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE},
> { "tile-rows", "Number of tile rows to use, log2",
> OFFSET(tile_rows), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 2, VE},
> { "frame-parallel", "Enable frame parallel decodability features",
> OFFSET(frame_parallel), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1, VE},
> + { "aq-mode", "adaptive quantization mode",
> OFFSET(aq_mode), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 3, VE},
This one needs "aq_mode" after VE as well. Otherwise none of the constants
below will work for it.
> + { "none", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = 0}, 0, 0, VE,
> "aq_mode" }, \
> + { "variance", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = 1}, 0, 0, VE,
> "aq_mode" }, \
> + { "complexity", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = 2}, 0, 0, VE,
> "aq_mode" }, \
> + { "cyclic", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = 3}, 0, 0, VE,
> "aq_mode" }, \
Instead of NULL you could write a short description for each of them.
> LEGACY_OPTIONS
> { NULL }
> };
>
LGTM otherwise.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
