Hi Le 10 août 2014 à 15:16, Christophe Gisquet <christophe.gisq...@gmail.com> a écrit :
> Hi, > > 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje <rsbul...@gmail.com>: >> Are we using the checked bitstream reader? If we are, we're fine already... > > I think we are. On the other hand, it seems the top caller, > ff_hevc_decode_nal_vps, is never checking if we have read past the > bitstream end. Shouldn't this be checked at the very end? Hitting the > bitstream end yet not reporting invalid data at some point looks weird > to me. > information from the vps is not used for the time being. and yes we are using the checked bitstream reader. we rely on the AVC cabac engine. > So, I'm just not sure this always yields vps/sps/... info, so catching > it might be good. On the other hand, this doesn't help catching bugs > in the code elsewhere. > >> If not, maybe we should, because let's be honest, getbits is only in >> headers, so it's not particularly performance-sensitive. > > And this is high-level syntax (think sps), so indeed. They are some missing checks in the PSes but I think most of them are there. Mickaël _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
