On Sun, Aug 03, 2014 at 01:59:25PM -0700, Timothy Gu wrote: > On Aug 3, 2014 1:27 PM, "Clément Bœsch" <u...@pkh.me> wrote: > > > > This removes the avcodec dependency and make the code almost twice as > > fast. More to come. > > > > The DCT factorization is based on "Fast and numerically stable > > algorithms for discrete cosine transforms" from Gerlind Plonkaa & > > Manfred Tasche (DOI: 10.1016/j.laa.2004.07.015). > > --- > > configure | 2 - > > libavfilter/vf_dctdnoiz.c | 328 > +++++++++++++++++++++++++++++++++------------- > > 2 files changed, 240 insertions(+), 90 deletions(-) > > This change warrants a Changelog entry. >
Not yet; I'd like to fully optimize it first.
[...]
> > static int config_input(AVFilterLink *inlink)
> > @@ -194,18 +373,13 @@ static av_cold int init(AVFilterContext *ctx)
> > NULL, NULL, NULL, NULL, 0, ctx);
> > if (ret < 0)
> > return ret;
>
> > + s->filter_freq_func = filter_freq_expr;
> > + } else {
> > + s->filter_freq_func = filter_freq_sigma;
> > }
>
> Missing "if (s->expr)"?
>
You mean error checking? That should be handled by ret < 0
[...]
--
Clément B.
pgpUTTKP9tozl.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
