On Mon, Jul 28, 2014 at 08:33:14PM +0200, Hendrik Leppkes wrote: > Am 28.07.2014 04:30 schrieb "Michael Niedermayer" <michae...@gmx.at>: > > diff --git a/libavutil/version.h b/libavutil/version.h > > index 6d8d6f0..1deb6e4 100644 > > --- a/libavutil/version.h > > +++ b/libavutil/version.h > > @@ -138,7 +138,7 @@ > > #define FF_API_OPT_TYPE_METADATA (LIBAVUTIL_VERSION_MAJOR < 54) > > #endif > > #ifndef FF_API_AVFRAME_COLORSPACE > > -#define FF_API_AVFRAME_COLORSPACE (LIBAVUTIL_VERSION_MAJOR >= 52) > > +#define FF_API_AVFRAME_COLORSPACE (LIBAVUTIL_VERSION_MAJOR >= 53) > > #endif > > This is stupid. If we cannot even add new fields to structs which are > defined to have their size not part of the ABI, we might as well give up on > improving the API. > > I'm against this. Broken user apps shouldn't dictate everything we do.
I know I kind of argued the same as you, but I just wanted to point out that I think that occasionally, out of pragmatism and for "avoid pain for users" reasons I think it's fine to do such things. We just shouldn't do it lightly, without being sure it is the most reasonable solution. At least that's my opinion. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
