On 07/24/2014 11:54 AM, Marton Balint wrote: > > On Thu, 24 Jul 2014, Michael Niedermayer wrote: > >> Hi >> >> On Thu, Jul 17, 2014 at 06:02:02PM -0700, Timothy Gu wrote: >>> Signed-off-by: Timothy Gu <timothyg...@gmail.com> >>> --- >>> ffplay.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/ffplay.c b/ffplay.c >>> index af0e199..8abbeae 100644 >>> --- a/ffplay.c >>> +++ b/ffplay.c >>> @@ -775,8 +775,6 @@ static void blend_subrect(AVPicture *dst, const >>> AVSubtitleRect *rect, int imgw, >>> lum[0] = ALPHA_BLEND(a, lum[0], y, 0); >>> >>> YUVA_IN(y, u, v, a, p + BPP, pal); >>> - u1 += u; >>> - v1 += v; >>> a1 += a; >>> lum[1] = ALPHA_BLEND(a, lum[1], y, 0); >>> cb[0] = ALPHA_BLEND(a1 >> 2, cb[0], u, 1); > > I have a feeling that the ALPHA_BLENDs should use u1 and v1 > respectively, and not u and v, so this is not the proper fix.
Consider this patch dropped, and do what you think is correct then. [...] Timothy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel