This is an automated email from the git hooks/post-receive script.

Git pushed a commit to branch master
in repository fateserver.

commit 8cc0b2e631dbff086184964c5e5d227a7a784925
Author:     Kacper Michajłow <[email protected]>
AuthorDate: Thu Jul 30 01:06:59 2026 +0200
Commit:     Kacper Michajłow <[email protected]>
CommitDate: Wed Aug 12 00:42:16 2026 +0200

    index,history: show a failure to build tests as a failure
    
    A run where every test passed but the status is non-zero failed to build
    the tests, which report.cgi already flags as a failure.
    
    Signed-off-by: Kacper Michajłow <[email protected]>
---
 history.cgi | 3 ++-
 index.cgi   | 9 ++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/history.cgi b/history.cgi
index 2cf97c0..0ca9d8a 100755
--- a/history.cgi
+++ b/history.cgi
@@ -92,7 +92,8 @@ for my $i (0 .. $nshow - 1) {
     end 'td';
     if ($npass) {
         $rtext  = "$npass / $ntest";
-        $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail';
+        $rclass = !$$rep{status}  ? 'pass' :
+                  $npass < $ntest ? 'warn' : 'fail';
     } elsif (!$ntest and !$$rep{status}) {
         $rtext  = "build only";
         $rclass = $$rep{status}? 'fail' : 'pass';
diff --git a/index.cgi b/index.cgi
index b0b1053..75302c3 100755
--- a/index.cgi
+++ b/index.cgi
@@ -75,8 +75,10 @@ for my $slot (@slots) {
     next if $not_matched;
 
     push @reps, $rep;
-    if ($$rep{npass} == $$rep{ntests} and !$$rep{status}) {
-        $allpass++;
+    if ($$rep{npass} == $$rep{ntests}) {
+        # All tests passed, or none were meant to run; a non-zero status
+        # still means the build failed.
+        $$rep{status} ? $allfail++ : $allpass++;
     } elsif ($$rep{npass} == 0) {
         $allfail++;
     }
@@ -302,7 +304,8 @@ for my $rep (sort repcmp @reps) {
     td $$rep{comment}, class => 'comment';
     if ($npass) {
         $rtext  = "$npass / $ntest";
-        $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail';
+        $rclass = !$$rep{status}  ? 'pass' :
+                  $npass < $ntest ? 'warn' : 'fail';
     } elsif (!$ntest and !$$rep{status}) {
         $rtext  = "build only";
         $rclass = $$rep{status}? 'fail' : 'pass';

_______________________________________________
ffmpeg-cvslog mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to