ffmpeg | branch: master | Reimar Döffinger <reimar.doeffin...@gmx.de> | Sat Dec 27 22:49:39 2014 +0100| [035180901de9bbea873001b82d96dd2b7a45d76a] | committer: Reimar Döffinger
r210enc.c: Simplify and never store more than 10 bits. The r10k and avrp decoders would previously store 12 bit precision for the blue channel, which is inconsistent and probably not a desirable behaviour. Now the 2 unused extra bits are set to 0. This is possibly not ideal either as RGBA1010102 format has the same layout but stores alpha in these bits, thus explicitly setting them to 1 might be preferable. Signed-off-by: Reimar Döffinger <reimar.doeffin...@gmx.de> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=035180901de9bbea873001b82d96dd2b7a45d76a --- libavcodec/r210enc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/r210enc.c b/libavcodec/r210enc.c index d61cd75..07dfc50 100644 --- a/libavcodec/r210enc.c +++ b/libavcodec/r210enc.c @@ -58,11 +58,11 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt, uint32_t pixel; uint16_t r = *src++ >> 6; uint16_t g = *src++ >> 6; - uint16_t b = *src++ >> 4; + uint16_t b = *src++ >> 6; if (avctx->codec_id == AV_CODEC_ID_R210) - pixel = (r << 20) | (g << 10) | b >> 2; + pixel = (r << 20) | (g << 10) | b; else - pixel = (r << 22) | (g << 12) | b; + pixel = (r << 22) | (g << 12) | (b << 2); if (avctx->codec_id == AV_CODEC_ID_AVRP) bytestream_put_le32(&dst, pixel); else _______________________________________________ ffmpeg-cvslog mailing list ffmpeg-cvslog@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog