hi First understand what *filename = Dir()* is doing, its basically providing next file name in folder for all file names..
So when you dont use *filename = Dir()* your *filename *variable is holding your firs file name, & your first file name is never gonna be "" unless its empty directory hence loop is continuing to infinite... Cheers!! +++++ *I did not do this for you. God is here working through me for you.* On Wed, Dec 3, 2014 at 4:18 PM, Mandeep Baluja <rockerna...@gmail.com> wrote: > Hey, > > I am working on this code if i will not use statement *filename = Dir()* > then it goes into a infinite stage. May I know the reason why and why it's > stopped when i apply this line. > as Per the meaning of this line it will check all the rest of files. > > Sub Select_Folder_and_copy_files_into_current_workbook() > > 'Variable declaration to hold the path of folder > Dim Sel_Folder As String > Dim filename As String > > With Application.FileDialog(msoFileDialogFolderPicker) > .AllowMultiSelect = False > .Show > Sel_Folder = .SelectedItems(1) > > MsgBox Sel_Folder > End With > > filename = Dir(Sel_Folder & "\" & "*.xlsx") > MsgBox filename > > Do While filename <> "" > > Set wb = Workbooks.Open(filename:=Sel_Folder & "\" & filename, local:=True) > > *filename = Dir()* > > Loop > > MsgBox " Done" > > End Sub > > -- > Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s > =TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @ > https://www.facebook.com/discussexcel > > FORUM RULES > > 1) Use concise, accurate thread titles. Poor thread titles, like Please > Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice > will not get quick attention or may not be answered. > 2) Don't post a question in the thread of another member. > 3) Don't post questions regarding breaking or bypassing any security > measure. > 4) Acknowledge the responses you receive, good or bad. > 5) Jobs posting is not allowed. > 6) Sharing copyrighted material and their links is not allowed. > > NOTE : Don't ever post confidential data in a workbook. Forum owners and > members are not responsible for any loss. > --- > You received this message because you are subscribed to the Google Groups > "MS EXCEL AND VBA MACROS" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to excel-macros+unsubscr...@googlegroups.com. > To post to this group, send email to excel-macros@googlegroups.com. > Visit this group at http://groups.google.com/group/excel-macros. > For more options, visit https://groups.google.com/d/optout. > -- Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s =TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Jobs posting is not allowed. 6) Sharing copyrighted material and their links is not allowed. NOTE : Don't ever post confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To unsubscribe from this group and stop receiving emails from it, send an email to excel-macros+unsubscr...@googlegroups.com. To post to this group, send email to excel-macros@googlegroups.com. Visit this group at http://groups.google.com/group/excel-macros. For more options, visit https://groups.google.com/d/optout.
