It worked fine for me, until I found a file that had an "issue". you could try something like:
Sub ProcessFiles() Dim fso, fld, fc, f Dim fldr, ext On Error GoTo BadExit Set fso = CreateObject("Scripting.FileSystemObject") fldr = "C:\temp\vba\" If (fso.folderexists(fldr)) Then Set fld = fso.getfolder(fldr) Set fc = fld.Files For Each f In fc If (fso.getextensionname(f.Name) = "xlsx") Then Workbooks.Open f.Path End If Next End If Exit Sub BadExit: MsgBox Err.Number & Chr(13) & Err.Description Debug.Assert False End Sub Paul ----------------------------------------- “Do all the good you can, By all the means you can, In all the ways you can, In all the places you can, At all the times you can, To all the people you can, As long as ever you can.” - John Wesley ----------------------------------------- From: Mandeep Baluja <rockerna...@gmail.com> >To: excel-macros@googlegroups.com >Sent: Tuesday, November 25, 2014 5:20 AM >Subject: $$Excel-Macros$$ Re: Folder looping > > > >Sub ProcessFiles() > Dim Filename, Pathname As String > Dim wb As Workbook > > > Pathname = "C:\Users\pc\Desktop\nov\NOV 01ST TO 19TH\" > > Filename = Dir(Pathname & "*.xlsx") > > Do While Filename <> "" > Workbooks.Open (Pathname & Filename) > Filename = Dir() > Loop >End Sub > > >the above code is not opening all the files. why ??? > >On Tuesday, November 25, 2014 3:41:16 PM UTC+5:30, Mandeep Baluja wrote: >Does anyone has another code except this to loop files in folder and perform >operation on that file. ?? this code is correct but i want different one. >> >> >>Sub ListFiles() >> >> >>Dim bookList As Workbook >>Dim mergeObj As Object, dirObj As Object, filesObj As Object, everyObj As >>Object >>Application.ScreenUpdating = False >>Set mergeObj = CreateObject("Scripting. FileSystemObject") >> >> >>'change folder path of excel files here >>Set dirObj = mergeObj.GetFolder("C:\Users\ pc\Desktop\nov\NOV 01ST TO 19TH") >>Set filesObj = dirObj.Files >>For Each everyObj In filesObj >>Set bookList = Workbooks.Open(everyObj) >> >> >>Sheets(1).Select >-- >Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s >=TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @ >https://www.facebook.com/discussexcel > >FORUM RULES > >1) Use concise, accurate thread titles. Poor thread titles, like Please Help, >Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get >quick attention or may not be answered. >2) Don't post a question in the thread of another member. >3) Don't post questions regarding breaking or bypassing any security measure. >4) Acknowledge the responses you receive, good or bad. >5) Jobs posting is not allowed. >6) Sharing copyrighted material and their links is not allowed. > >NOTE : Don't ever post confidential data in a workbook. Forum owners and >members are not responsible for any loss. >--- >You received this message because you are subscribed to the Google Groups "MS >EXCEL AND VBA MACROS" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to excel-macros+unsubscr...@googlegroups.com. >To post to this group, send email to excel-macros@googlegroups.com. >Visit this group at http://groups.google.com/group/excel-macros. >For more options, visit https://groups.google.com/d/optout. > > > -- Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s =TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Jobs posting is not allowed. 6) Sharing copyrighted material and their links is not allowed. NOTE : Don't ever post confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To unsubscribe from this group and stop receiving emails from it, send an email to excel-macros+unsubscr...@googlegroups.com. To post to this group, send email to excel-macros@googlegroups.com. Visit this group at http://groups.google.com/group/excel-macros. For more options, visit https://groups.google.com/d/optout.