What line is giving you a mismatch error?
What are the values of the two cells being compared?
also, you're setting LR = the last row of data in column "A",
but then never use the value (so it's unnecessary).
I ran this macro on a sample file that had 132,000 rows and it worked as I
expected it to.
So, I suspect that your data has an improper date in a cell.
Excel considers dates as numbers (the number of days since 1/1/1900)
So today (4/16/2014) is 41745 since 1/1/1900.
your statement:
If Cells(i, "A") < Cells(i + 1, "A") - 1 Then
is comparing the value of two numbers.
If one of your cells is an incorrect date, then it will not be able to subtract
1 from the value.
Try adding a date check:
Dim LR As Long, i As Long
Application.ScreenUpdating = False
LR = Range("A" & Rows.Count).End(xlUp).Row
i = 2
Do Until Cells(i, "A") = ""
'----------------------------------------------------
' Check for valid date format
'----------------------------------------------------
If (Not IsDate(Cells(i + 1, "A").Value)) Then
MsgBox "Row: " & i + 1 & Chr(13) & Cells(i + 1, "A").Value &
Chr(13) & "Is not a valid date"
Exit Sub
End If
'----------------------------------------------------
If Cells(i, "A") < Cells(i + 1, "A") - 1 Then
Rows(i + 1).Insert xlShiftDown
Cells(i + 1, "A") = Cells(i, "A") + 1
Cells(i + 1, "B") = 0
End If
i = i + 1
Loop
Application.ScreenUpdating = True
Paul
-----------------------------------------
“Do all the good you can,
By all the means you can,
In all the ways you can,
In all the places you can,
At all the times you can,
To all the people you can,
As long as ever you can.” - John Wesley
-----------------------------------------
>________________________________
> From: shailesh Shah <shahvshail...@gmail.com>
>To: excel-macros@googlegroups.com
>Sent: Wednesday, April 16, 2014 2:23 AM
>Subject: $$Excel-Macros$$ inserting missing date in data
>
>
>
>i have found a macro from the internet to add missing date in the data. its
>not working in excel 2010. it is giving type mismatch error.
>would appreciate if i get guided.
>
>
>Option Explicit
>Sub AddMissingDates()
>'JBeaucaire (12/13/2009)
>Dim LR As Long, i As
Long
>Application.ScreenUpdating = False
>LR = Range("A" &
Rows.Count).End(xlUp).Row
>i = 2
> Do Until Cells(i, "A") = ""
> If Cells(i, "A") < Cells(i + 1,
"A") - 1 Then
> Rows(i + 1).Insert xlShiftDown
>
Cells(i + 1, "A") = Cells(i, "A") + 1
> Cells(i + 1, "B") =
0
> End If
> i = i + 1
> Loop
>Application.ScreenUpdating = True
>End Sub
>
>
>
>appreciate response.
--
>Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s
>=TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @
>https://www.facebook.com/discussexcel
>
>FORUM RULES
>
>1) Use concise, accurate thread titles. Poor thread titles, like Please Help,
>Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get
>quick attention or may not be answered.
>2) Don't post a question in the thread of another member.
>3) Don't post questions regarding breaking or bypassing any security measure.
>4) Acknowledge the responses you receive, good or bad.
>5) Jobs posting is not allowed.
>6) Sharing copyrighted material and their links is not allowed.
>
>NOTE : Don't ever post confidential data in a workbook. Forum owners and
>members are not responsible for any loss.
>---
>You received this message because you are subscribed to the Google Groups "MS
>EXCEL AND VBA MACROS" group.
>To unsubscribe from this group and stop receiving emails from it, send an
>email to excel-macros+unsubscr...@googlegroups.com.
>To post to this group, send email to excel-macros@googlegroups.com.
>Visit this group at http://groups.google.com/group/excel-macros.
>For more options, visit https://groups.google.com/d/optout.
>
>
>
--
Are you =EXP(E:RT) or =NOT(EXP(E:RT)) in Excel? And do you wanna be? It’s
=TIME(2,DO:IT,N:OW) ! Join official Facebook page of this forum @
https://www.facebook.com/discussexcel
FORUM RULES
1) Use concise, accurate thread titles. Poor thread titles, like Please Help,
Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get
quick attention or may not be answered.
2) Don't post a question in the thread of another member.
3) Don't post questions regarding breaking or bypassing any security measure.
4) Acknowledge the responses you receive, good or bad.
5) Jobs posting is not allowed.
6) Sharing copyrighted material and their links is not allowed.
NOTE : Don't ever post confidential data in a workbook. Forum owners and
members are not responsible for any loss.
---
You received this message because you are subscribed to the Google Groups "MS
EXCEL AND VBA MACROS" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to excel-macros+unsubscr...@googlegroups.com.
To post to this group, send email to excel-macros@googlegroups.com.
Visit this group at http://groups.google.com/group/excel-macros.
For more options, visit https://groups.google.com/d/optout.
