just found that you're defining the fpath only if you select "Yes".
also, I suggest you use Option Explicit at the top of your module. This will ensure that you have all variables declared. If I do that, it says that Quit = True is defining a new variable called "Quit" and setting it to "true". I'm not sure that is what you intended. good luck. Paul ----------------------------------------- “Do all the good you can, By all the means you can, In all the ways you can, In all the places you can, At all the times you can, To all the people you can, As long as ever you can.” - John Wesley ----------------------------------------- ________________________________ From: Darren Combellack <dar...@combellack.co.uk> To: "excel-macros@googlegroups.com" <excel-macros@googlegroups.com> Sent: Wed, September 5, 2012 8:35:05 AM Subject: RE: $$Excel-Macros$$ Excel Macro Not to worry, Sorted it. Thanks you so much for all your help, you’d saved me HOURS. I will be sure to recommend this site. Many thanks Darren Combellack From:excel-macros@googlegroups.com [mailto:excel-macros@googlegroups.com] On Behalf Of Paul Schreiner Sent: 05 September 2012 12:18 To: excel-macros@googlegroups.com Subject: Re: $$Excel-Macros$$ Excel Macro the Filename is a fully "delineated" name. That is to say, it is intended to be the full path and file name. If not path is specified, the default path is used. If fPath is defined, then you can use: ActiveWorkbook.SaveAs Filename:= fPath & "Incomplete" & " - " & Range("G4").Value & ".xlsm", FileFormat:= xlOpenXMLWorkbookMacroEnabled Be sure that fPath has a trailing "\" Paul ----------------------------------------- “Do all the good you can, By all the means you can, In all the ways you can, In all the places you can, At all the times you can, To all the people you can, As long as ever you can.” - John Wesley ----------------------------------------- ________________________________ From:combellack <dar...@combellack.co.uk> To: excel-macros@googlegroups.com Sent: Wed, September 5, 2012 4:27:10 AM Subject: Re: $$Excel-Macros$$ Excel Macro Thanks Paul, That make sense, and works perfect. Where should I add the 'fPath' within that line, currently its saving to my document, but I would like it to save to Dropbox. fPath = "\\SBS1\dropbox\Purchase Order" On Tuesday, 4 September 2012 14:36:43 UTC+1, Paul Schreiner wrote: I think it's trying to save as an .xlsx format even though you've specificed a .xlsm file extension. (you never really TOLD .SaveAS which file format to use) Remember that File FORMATS and File EXTENSIONS are not the same thing. Just because you change the extension on a .xlsx file to .doc doesn't mean that it suddenly becomes a Word file. It still is in the original format. It may be that your Mac isn't checking for the format/extension to match. and is allowing you to save a file in one format to a different extension. So.. Let's try fixing the saveas syntax. try: ActiveWorkbook.SaveAs Filename:="Incomplete" & " - " & Range("G4").Value & ".xlsm", FileFormat:= xlOpenXMLWorkbookMacroEnabled Paul ------------------------------ ----------- “Do all the good you can, By all the means you can, In all the ways you can, In all the places you can, At all the times you can, To all the people you can, As long as ever you can.” - John Wesley ------------------------------ ----------- ________________________________ From:combellack <dar...@combellack.co.uk> To: excel-...@googlegroups.com Sent: Tue, September 4, 2012 8:59:44 AM Subject: Re: $$Excel-Macros$$ Excel Macro Hi Paul, here's the first error mwssage, when i click 'No' in the message box. if i then click 'NO', i get this Debug show's this I'm added "xlsm" at the end because i thought it may had been an file extenison issue. The Value range("G4") is the cell in which we enter our Purchase Order Number. If i click 'Yes' on the first message box, the file is converted to PDF perferct, its only when i click 'NO' so i can edit it later. The stangest thing, its works perfect on my Mac, saves to Dropbox, and open's on Windows fine. I only get this error when i click 'NO' in the first message box. 'Yes' & 'Cancel' work fine. On Tuesday, 4 September 2012 13:35:30 UTC+1, Paul Schreiner wrote: Sorry about my previous message. I didn't finish reading... What does the error message read? what is the value of Range("G4") and... wouldn't the line following elseif PO = vbCancel then Cancel = true ?? Paul ------------------------------ ----------- “Do all the good you can, By all the means you can, In all the ways you can, In all the places you can, At all the times you can, To all the people you can, As long as ever you can.” - John Wesley ------------------------------ ----------- ________________________________ From:combellack <dar...@combellack.co.uk> To: excel-...@googlegroups.com Sent: Tue, September 4, 2012 8:17:40 AM Subject: $$Excel-Macros$$ Excel Macro I was hope you could help! I wrote a VB Code for Excel (mainly copied for Google!) to help us when raising purchase orders. I wrote it on my mac within Office 2010, and I ran perfect. Unfortunately when I try on Windows (also Office 2010) I get a debug error? Private Sub Workbook_BeforeClose(Cancel As Boolean) Dim PO As Long PO = MsgBox("Is the Purchase Order complete?", vbYesNoCancel) If PO = vbYes Then Me.Saved = True Dim fName As String, fPath As String fName = Range("G4").Value fPath = "\\SBS1\dropbox\Purchase Order" ActiveWorkbook. ExportAsFixedFormat _ Type:=xlTypePDF, _ Filename:=fPath & "/" & fName, _ Quality:=xlQualityStandard, _ IncludeDocProperties:=True, _ IgnorePrintAreas:=False, _ OpenAfterPublish:=True ElseIf PO = vbNo Then ActiveWorkbook.SaveAs Filename:="Incomplete" & " - " & Range("G4").Value & ".xlsm" ElseIf PO = vbCancel Then Quit = True End If End Sub Windows Office is showing the error as being ElseIf PO = vbNo Then ActiveWorkbook.SaveAs Filename:="Incomplete" & " - " & Range("G4").Value & ".xlsm" What have I done wrong? -- Join official facebook page of this forum @ https://www.facebook.com/ discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-...@googlegroups.com. To unsubscribe from this group, send email to excel-macros...@ googlegroups.com. -- Join official facebook page of this forum @ https://www.facebook.com/ discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-...@googlegroups.com. To unsubscribe from this group, send email to excel-macros...@ googlegroups.com. -- Join official facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-macros@googlegroups.com. To unsubscribe from this group, send email to excel-macros+unsubscr...@googlegroups.com. -- Join official facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-macros@googlegroups.com. To unsubscribe from this group, send email to excel-macros+unsubscr...@googlegroups.com. -- Join official facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-macros@googlegroups.com. To unsubscribe from this group, send email to excel-macros+unsubscr...@googlegroups.com. -- Join official facebook page of this forum @ https://www.facebook.com/discussexcel FORUM RULES (1120+ members already BANNED for violation) 1) Use concise, accurate thread titles. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get quick attention or may not be answered. 2) Don't post a question in the thread of another member. 3) Don't post questions regarding breaking or bypassing any security measure. 4) Acknowledge the responses you receive, good or bad. 5) Cross-promotion of, or links to, forums competitive to this forum in signatures are prohibited. 6) Jobs posting is not allowed. 7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed. NOTE : Don't ever post personal or confidential data in a workbook. Forum owners and members are not responsible for any loss. --- You received this message because you are subscribed to the Google Groups "MS EXCEL AND VBA MACROS" group. To post to this group, send email to excel-macros@googlegroups.com. To unsubscribe from this group, send email to excel-macros+unsubscr...@googlegroups.com.
