The changes in fixes/unittests<http://github.com/gopaczewski/erma/commit/b15a1e40e1a23faa1e1c2674dd943e26fccc9ef4>look good. You should make sure to merge them with the 3.2 release.
I improved the javadocs for the Monitor implementation classes. There's also some minor refactoring (mostly standardizing variable names). The branch is javadoc<http://github.com/mkemp/erma/commit/43f9685a555f487e52e1089ed6c124f65e8d1492> . Matt On Sat, Dec 20, 2008 at 6:18 AM, Greg Opaczewski <gopaczew...@gmail.com>wrote: > git is so sweet I decided to start writing code again :) > > I was seeing occasional failures of that unit test also, here's my attempt > at making it reliable: > http://github.com/gopaczewski/erma/commits/fixes/unittests > > I also modified jira to add in a Ready For Review step in our workflow. I > didn't screw with custom fields for the branch name or anything like that > because I didn't want to piss Alex off by messing up our install. Maybe if > we're nice he'll help us clean that up a bit. > > Greg > > On Fri, Dec 12, 2008 at 11:34 AM, Matthew Kemp <mattk...@gmail.com> wrote: > >> I incorporated Doug's build fix and have pushed it to git:// >> github.com/mkemp/erma.git. Moving forward is the consensus that instead >> of pushing to master on github that we should push to a feature branch? If >> so any suggestions on a standard such as a jira number or relevant name? >> >> Also, I noticed that DeadLockDetectionTimerTaskTest fails occasionally. >> Has anyone else had this problem? If so I will will switch the asserts to >> print stantments. >> >> Matt >> >> >> >> On Thu, Dec 11, 2008 at 11:13 AM, Matthew Kemp <mattk...@gmail.com>wrote: >> >>> It must be something weird with the dependencies of the version of ant >>> that I was using. I was able to build successfully with a clean version of >>> ant. >>> >>> Matt >>> >>> >>> On Wed, Dec 10, 2008 at 2:18 PM, Doug Barth <dougba...@gmail.com> wrote: >>> >>>> On Dec 10, 2008, at 2:14 PM, Matthew Kemp wrote: >>>> >>>> Your changes look good, but I still can't get it to work on my machine. >>>>> >>>> >>>> >>>> Perhaps one of the JARs bundled with your JDK/Ant package are getting >>>> picked up and have more dependencies than the JARs in the project? Can you >>>> try moving aside the JARs in those directories and see if the problem goes >>>> away? If it does, just swap out the JARs I put in the project with the ones >>>> for your build. >>>> >>>> -- >>>> Doug Barth >>>> >>>> >>> >> >> _______________________________________________ >> Mailing list: >> https://launchpad.net/~erma-core<https://launchpad.net/%7Eerma-core> >> Post to : erma-core@lists.launchpad.net >> Unsubscribe : >> https://launchpad.net/~erma-core<https://launchpad.net/%7Eerma-core> >> More help : https://help.launchpad.net/ListHelp >> >> >
_______________________________________________ Mailing list: https://launchpad.net/~erma-core Post to : erma-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~erma-core More help : https://help.launchpad.net/ListHelp
