I don't think we actually use ThreadLocal anywhere, do we?  All of the magic is 
handled with a ConcurrentMap field in MonitoringEngine.

-Matt

-----Original Message-----
From: erma-core-bounces+mokeefe=orbitz....@lists.launchpad.net 
[mailto:erma-core-bounces+mokeefe=orbitz....@lists.launchpad.net] On Behalf Of 
Ray Krueger
Sent: Sunday, December 14, 2008 7:17 PM
To: erma-core@lists.launchpad.net
Subject: [Erma-core] Mavenizing Erma (Again)

I'm working on Mavenizing Erma on a fork I started. I tried this
before but bzr made it a huge pain in the ass. This time around Git is
making it much more pleasant. I've divided the code base into two
modules the 1.4 stuff and the 1.5 stuff. Erma-core is the main 1.4
project, Erma-tiger is the 1.5 specific things like the Annotations
and some of the JMX magic.

It isn't done yet, but it's a solid start
http://github.com/raykrueger/erma/tree/master

Again, the last time I tried this the tests were an issue, this is no
different. The erma-core tests are very fragile due to the ThreadLocal
stuff they do. Over time when one test was affected by a previous
test, it was fixed till it worked. That pattern only works when all
the tests run in the same order all the time. Obviously that's pretty
fragile as just trying to run them in your IDE vs the command line
will cause the to fail at random. I think the final solution for this
is probably going to be to create some common TestCase superclass that
cleans up all the threadlocal stuff on every run for every test. I
haven't had time to invest in that yet though.

Right now the stuff in my fork is moving nicely, erma-tiger tests
complete fine. Once I get erma-core and the release cycle stuff setup
we can talk about it more. If anyone wants to jump in and help figure
out the unit tests you can fork my fork :) I'd love the help!

_______________________________________________
Mailing list: https://launchpad.net/~erma-core
Post to     : erma-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~erma-core
More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~erma-core
Post to     : erma-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~erma-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to