This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch span-gl-clean
in repository efl.
View the commit online.
commit 80ca6fded83b7c019053b282a10c0e921c98b512
Author: [email protected] <[email protected]>
AuthorDate: Sun Sep 13 22:39:45 2026 -0600
evas_ector_gl: drop stray double blank lines
The review spotted an extra blank line at the top of evas_gl_context.c,
which left two blank lines in a row between the PRG_INVALID define and
the file's static variables. EFL separates blocks with a single blank
line.
Scanning every line this branch adds found four more in the new
evas_ector_gl_span_shader.c: in _span_pbo_usable(), after the stroke
sampler uniforms, in span_shader_shutdown() and after
_span_draw_batch(). Remove all five.
Only blank lines are removed, and all of them were added by this branch.
The build is clean, and ector_suite and evas_suite pass.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
---
src/modules/evas/engines/gl_common/evas_gl_context.c | 1 -
src/modules/evas/engines/gl_generic/evas_ector_gl_span_shader.c | 4 ----
2 files changed, 5 deletions(-)
diff --git a/src/modules/evas/engines/gl_common/evas_gl_context.c b/src/modules/evas/engines/gl_common/evas_gl_context.c
index 8f9afc3f71..cad6d599b2 100644
--- a/src/modules/evas/engines/gl_common/evas_gl_context.c
+++ b/src/modules/evas/engines/gl_common/evas_gl_context.c
@@ -11,7 +11,6 @@
#define PRG_INVALID NULL
-
static int tbm_sym_done = 0;
int _evas_engine_GL_common_log_dom = -1;
Cutout_Rects *_evas_gl_common_cutout_rects = NULL;
diff --git a/src/modules/evas/engines/gl_generic/evas_ector_gl_span_shader.c b/src/modules/evas/engines/gl_generic/evas_ector_gl_span_shader.c
index a2f4be721f..e9f3a788f6 100644
--- a/src/modules/evas/engines/gl_generic/evas_ector_gl_span_shader.c
+++ b/src/modules/evas/engines/gl_generic/evas_ector_gl_span_shader.c
@@ -94,7 +94,6 @@ _span_pbo_usable(void)
(ext && strstr(ext, "pixel_buffer_object")))
_span_pbo_ok = 1;
-
if (!_span_pbo_ok)
INF("span shader: no pixel buffer objects, uploading from client memory");
return _span_pbo_ok;
@@ -431,7 +430,6 @@ static const char _glsl_uniforms_bind_s[] =
"uniform sampler2D u_stroke_spans;\n"
"uniform sampler2D u_fill_spans;\n";
-
// Composite mask uniforms (present only in *_mask variants).
// Only the sampler remains; size, offset, op, inv moved to varyings.
static const char _glsl_uniforms_mask[] =
@@ -1274,7 +1272,6 @@ span_shader_shutdown(void)
}
_span_pbo_ok = -1;
-
free(_span_pack_buf);
_span_pack_buf = NULL;
_span_pack_sz = 0;
@@ -1709,7 +1706,6 @@ _span_draw_batch(Evas_Engine_GL_Context *gc, Span_Variant variant,
gc->state.current.ch = 0;
}
-
// ------------------------------------------------------------------
// Direct VG pass
// ------------------------------------------------------------------
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.