This is an automated email from the git hooks/post-receive script.
git pushed a commit to reference refs/pull/114/head
in repository efl.
View the commit online.
commit 1484b25d6a6b424d659fb5fa1cc7e6d5fc1346ee
Author: [email protected] <[email protected]>
AuthorDate: Sun Sep 13 18:46:22 2026 -0600
evas_ector_gl: test memcmp() with ! as EFL code does
The review pointed out that EFL writes !memcmp(...) rather than
memcmp(...) == 0. _find_by_content() in the gradient atlas was the only
place on this branch using the == 0 form; switch it over.
The other comparisons the branch adds already follow the idiom:
!strcmp() for equality and a bare strcmp() for inequality. The
ck_assert_int_ne(memcmp(...), 0) in the atlas unit test is an assertion
argument, not a condition, and stays as is.
No behaviour change. The build is clean, and ector_suite (including the
gradient atlas tests) and evas_suite pass.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
---
src/modules/evas/engines/gl_generic/evas_ector_gl_grad_atlas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/modules/evas/engines/gl_generic/evas_ector_gl_grad_atlas.c b/src/modules/evas/engines/gl_generic/evas_ector_gl_grad_atlas.c
index ba280e4d62..ac31227bae 100644
--- a/src/modules/evas/engines/gl_generic/evas_ector_gl_grad_atlas.c
+++ b/src/modules/evas/engines/gl_generic/evas_ector_gl_grad_atlas.c
@@ -142,8 +142,8 @@ _find_by_content(Span_Grad_Atlas *a, uint32_t hash, const uint8_t *bytes)
{
if (!a->rows[i].occupied) continue;
if (a->rows[i].hash != hash) continue;
- if (memcmp(a->cpu_mirror + ((size_t)i * SPAN_GRAD_ATLAS_ROW_BYTES),
- bytes, SPAN_GRAD_ATLAS_ROW_BYTES) == 0)
+ if (!memcmp(a->cpu_mirror + ((size_t)i * SPAN_GRAD_ATLAS_ROW_BYTES),
+ bytes, SPAN_GRAD_ATLAS_ROW_BYTES))
return i;
}
return -1;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
