Moti Asayag has posted comments on this change. Change subject: core: add updateAndReorderNics util class ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40031/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java: Line 113: */ Line 114: @EditableDeviceOnVmStatusField(generalType = VmDeviceGeneralType.GRAPHICS, type = VmDeviceType.UNKNOWN) Line 115: private Map<GraphicsType, GraphicsDevice> graphicsDevices; Line 116: Line 117: private List<VmNetworkInterface> updatedNetworkInterfaces; i'd expect to have the interfaces specified by the client at VmManagementParametersBase.getVm().getInterfaces() If it is set to null, the interfaces should be taken from the template. Any none value should represent the expected interfaces to be set for that vm: 1. empty list - no interface. 2. non empty list - the interfaces that the engine will order. With that approach there is no need for add/update/remove nics. All needed to do is reorder them by invoking the reorder nics command internally. Line 118: Line 119: public VmManagementParametersBase() { Line 120: init(); Line 121: } -- To view, visit https://gerrit.ovirt.org/40031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ca26b82f7a042a4ddfa6247d5fe2b995185c90 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
