Roy Golan has posted comments on this change. Change subject: core: enable pinning to multiple hosts ......................................................................
Patch Set 11: (2 comments) +1 BE except minor https://gerrit.ovirt.org/#/c/41962/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java: Line 84: <Guid> > vm.setDedicatedVmForVdsList(Collections.emptyList()); ok maybe here java has problem inferring that. I think jdk 8 fixed that https://gerrit.ovirt.org/#/c/41962/11/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1445: ACTION_TYPE_FAILED_SCSI_RESERVATION_NOT_VALID_FOR_FLOATING_DISK=Cannot ${action} ${type}. SCSI reservation cannot be set when adding floating disks. Line 1446: ACTION_TYPE_FAILED_SGIO_IS_FILTERED=Cannot ${action} ${type}. SCSI reservation can be set only when SGIO is unfiltered. Line 1447: Line 1448: ACTION_TYPE_FAILED_VM_NOT_PINNED_TO_HOST=Cannot ${action} ${type}. VM must be pinned to a host. Line 1449: ACTION_TYPE_FAILED_VM_PINNED_TO_MULTIPLE_HOSTS=Cannot ${action} ${type}. VM must be pinned to a single host. > The failed action is stated in ${action} ${type} ok Line 1450: ACTION_TYPE_FAILED_HOST_DEVICE_NOT_FOUND=Cannot ${action} ${type}. One or more of specified host devices not found. Line 1451: ACTION_TYPE_FAILED_HOST_DEVICE_NOT_AVAILABLE=Cannot ${action} ${type}. One or more configured host devices are unavailable. Line 1452: Line 1453: # vm icons -- To view, visit https://gerrit.ovirt.org/41962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I710bd8d3505552a2a8d6060194d94c68c05445db Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
