anmolbabu has posted comments on this change. Change subject: webadmin, engine : Error handling in geo-rep create ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42300/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2187: protected VdcReturnValueBase convertToVdcReturnValueBase(final VDSReturnValue vdsReturnValue) { Line 2188: VdcReturnValueBase returnValue = new VdcReturnValueBase(); Line 2189: returnValue.setSucceeded(false); Line 2190: returnValue.setActionReturnValue(vdsReturnValue.getReturnValue()); Line 2191: returnValue.setExecuteFailedMessages(new ArrayList<String>() > Done Sorry this VdcReturnValueBase#setExecuteFailedMessages takes an arraylist but Collections#singletonList gives me a list. Line 2192: {{ Line 2193: add(vdsReturnValue.getVdsError().getMessage()); Line 2194: }} Line 2195: ); -- To view, visit https://gerrit.ovirt.org/42300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
