Omer Frenkel has posted comments on this change.

Change subject: db: Fix size of guest memory information from INTEGER => BIGINT
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/41946/2/packaging/dbscripts/vms_sp.sql
File packaging/dbscripts/vms_sp.sql:

Line 273:   v_spice_ip varchar(32),
Line 274:   v_vnc_port INTEGER,
Line 275:   v_vnc_ip varchar(32),
Line 276:   v_guest_agent_status INTEGER,
Line 277:   v_guest_mem_free INTEGER,
this should be bigint
Line 278:   v_guest_mem_buffered BIGINT,
Line 279:   v_guest_mem_cached BIGINT,
Line 280:   v_guest_timezone_offset BIGINT,
Line 281:   v_guest_timezone_name VARCHAR(255),


Line 276:   v_guest_agent_status INTEGER,
Line 277:   v_guest_mem_free INTEGER,
Line 278:   v_guest_mem_buffered BIGINT,
Line 279:   v_guest_mem_cached BIGINT,
Line 280:   v_guest_timezone_offset BIGINT,
this i dont know
Line 281:   v_guest_timezone_name VARCHAR(255),
Line 282:   v_guestos_arch INTEGER,
Line 283:   v_guestos_codename VARCHAR(255),
Line 284:   v_guestos_distribution VARCHAR(255),


-- 
To view, visit https://gerrit.ovirt.org/41946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88a5a0e73a1f41caabb1fa88e7fb140c651056db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to