Tomas Jelinek has posted comments on this change.

Change subject: userportal\webadmin: Editing of template version for pools
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/36510/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java:

Line 321:         });
Line 322: 
Line 323:         PoolModel model = new PoolModel(behavior);
Line 324:         
model.setCustomPropertiesKeysList(AsyncDataProvider.getInstance().getCustomPropertiesList());
Line 325:         model.startProgress("");
It can take 3 server calls to return one by one until you get here to show the 
dialog with a progress bar. This can be a lot of time especially in slow 
networks and bigger environments. There it could look like clicking the edit 
did nothing leading to poor user experience.
Line 326:         model.setIsAdvancedModeLocalStorageKey("wa_pool_dialog");  
//$NON-NLS-1$
Line 327:         setWindow(model);
Line 328: 
Line 329:         VmBasedWidgetSwitchModeCommand switchModeCommand = new 
VmBasedWidgetSwitchModeCommand();


-- 
To view, visit https://gerrit.ovirt.org/36510
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53686dae694f6ff826bdbeaada1e28fc55fd8d30
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eldan Shachar <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to