Roy Golan has submitted this change and it was merged. Change subject: core: Fix FB issue in VdsCpuUsageComparator ......................................................................
core: Fix FB issue in VdsCpuUsageComparator This patch fixes the following FindBugs warning on this class: """ Se: Comparator doesn't implement Serializable (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE) This class implements the Comparator interface. You should consider whether or not it should also implement the Serializable interface. If a comparator is used to construct an ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator is also serializable. As most comparators have little or no state, making them serializable is generally easy and good defensive programming. """ Change-Id: Iedbed23022e170c5b9486b4af26ac9ed1eec96eb Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUsageComparator.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedbed23022e170c5b9486b4af26ac9ed1eec96eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
