Alona Kaplan has posted comments on this change. Change subject: webadmin: Change Setup Networks label mechanism ......................................................................
Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/38773/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 260: Line 261: // OK Target Line 262: okTarget = new BaseCommandTarget() { Line 263: @Override Line 264: public void executeCommand(UICommand command) { Why sourceListModel.setConfirmWindow(null) was removed? Line 265: setBondOptions(entity, bondDialogModel); Line 266: } Line 267: }; Line 268: } else if (item instanceof LogicalNetworkModel) { Line 457: networkCommand.execute(bond); Line 458: redraw(); Line 459: Line 460: // Attach the previous networks Line 461: for (NetworkInterfaceModel nic : getNics()) { Please use nicMap.get(iface.getName()); Line 462: if (nic.getName().equals(bond.getName())) { Line 463: NetworkOperation.attachNetworks(nic, networks, allNics); Line 464: redraw(); Line 465: return; https://gerrit.ovirt.org/#/c/38773/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksLabelModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksLabelModel.java: Line 27: label.validateEntity(new IValidation[] { new NotEmptyValidation(), new labelNotTakenValidation() }); Line 28: return label.getIsValid(); Line 29: } Line 30: Line 31: private class labelNotTakenValidation implements IValidation { Class name should start with capital letter. Line 32: Line 33: @Override Line 34: public ValidationResult validate(Object value) { Line 35: ValidationResult res = new ValidationResult(); https://gerrit.ovirt.org/#/c/38773/8/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java: Line 49: if (statusImage != null) { Line 50: rowPanel.setWidget(0, 1, new Image(statusImage)); Line 51: } Line 52: rowPanel.setWidget(0, 2, nicImage); Line 53: rowPanel.setWidget(0, 3, titleLabel); Needed for sr-iov Line 54: return rowPanel; Line 55: } Line 56: Line 57: private ImageResource getStatusImage() { Line 68: } Line 69: Line 70: @Override Line 71: protected void onAction() { Line 72: // Do nothing same Line 73: } -- To view, visit https://gerrit.ovirt.org/38773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762d06545f621c7a83896f9fa7c59f7b54e2e7ee Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
