Vered Volansky has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 43: (5 comments) https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 1647: Line 1648: @DefaultStringValue("Cannot extend Storage Domain. Storage device ${lun} is unreachable from ${hostName}.") Line 1649: String ERROR_CANNOT_EXTEND_CONNECTION_FAILED(); Line 1650: Line 1651: @DefaultStringValue("Cannot ${action} ${type}. Cannot ${action} ${type}. Can only update the following fields: name, description, comment, wipe after delete, low space threshold, and critical space threshold.") > a single "Cannot ${action} ${type}." is enough :) Done Line 1652: String ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS(); Line 1653: Line 1654: @DefaultStringValue("Cannot update Data Center compatibility version to a value that is greater than its Cluster's version. The following clusters should be upgraded ${ClustersList}.") Line 1655: String ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS(); https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1038: onSaveSanStorage(); Line 1039: } Line 1040: } Line 1041: Line 1042: private void saveMostStorageProperties(StorageModel model) { > consider renaming to a more specific method name... I know this is bad, couldn't come up with a better one. I can overload saveCommonStorageProperties, but this just seems bad in it's own way. Other suggestions are welcome. Line 1043: boolean isNew = model.getStorage() == null; Line 1044: storageDomain.setStorageType(isNew ? storageModel.getType() : storageDomain.getStorageType()); Line 1045: storageDomain.setStorageDomainType(isNew ? storageModel.getRole() : storageDomain.getStorageDomainType()); Line 1046: storageDomain.setDescription(model.getDescription().getEntity()); https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java: Line 44: Line 45: public class StorageModel extends ListModel<IStorageModel> implements ISupportSystemTreeContext Line 46: { Line 47: public static final Guid UnassignedDataCenterId = Guid.Empty; Line 48: > please move these constants to some place common - e.g. StorageConstants Done Line 49: //low space threshold maximum value (%) Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; Line 45: public class StorageModel extends ListModel<IStorageModel> implements ISupportSystemTreeContext Line 46: { Line 47: public static final Guid UnassignedDataCenterId = Guid.Empty; Line 48: Line 49: //low space threshold maximum value (%) > add space after '//' Done Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; Line 53: Line 47: public static final Guid UnassignedDataCenterId = Guid.Empty; Line 48: Line 49: //low space threshold maximum value (%) Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) > same Done Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; Line 53: Line 54: private StorageModelBehavior behavior; Line 55: -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
