Piotr Kliczewski has posted comments on this change. Change subject: wip: async vdscommand ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/40565/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 487: return (VDSAsyncReturnValue) value; Line 488: } Line 489: } Line 490: Line 491: return null; > consider throwing an exception in this case. I wanted to be consistent with semantics of this class. Everywhere we return null. Line 492: } Line 493: Line 494: public <P extends VdsIdVDSCommandParametersBase> FutureVDSCall<VDSReturnValue> runFutureVdsCommand(final FutureVDSCommandType commandType, Line 495: final P parameters) { https://gerrit.ovirt.org/#/c/40565/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 45: { > what about the proceedProxtReturnValue(). Don't we need it anymore? proceedProxyReturnValue uses the response so it is not good place to use it as it is when using async. We need to have this logic but as part of callback. Will fix. Line 62: setAsyncResult > Great progress! Irs broker is not good place to implement logic like this. There can be vds or irs commands. I will look for more generic mechanism. -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
