Allon Mureinik has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 39: Code-Review-1 (2 comments) I fetched and built locally - these changed are indeed redundant - please remove them. https://gerrit.ovirt.org/#/c/35277/39/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java: Line 36: @Rule Line 37: public MockConfigRule mcr = new MockConfigRule( Line 38: mockConfig(ConfigValues.CriticalSpaceActionBlocker, CRITICAL_SPACE_THRESHOLD), Line 39: mockConfig(ConfigValues.WarningLowSpaceIndicator, LOW_SPACE_THRESHOLD) Line 40: ); These changes are redundant - the test suite passes without them. Line 41: Line 42: public BackendStorageDomainResourceTest() { Line 43: super(new BackendStorageDomainResource(GUIDS[0].toString(), new BackendStorageDomainsResource())); Line 44: } https://gerrit.ovirt.org/#/c/35277/39/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java: Line 65: @Rule Line 66: public MockConfigRule mcr = new MockConfigRule( Line 67: mockConfig(ConfigValues.CriticalSpaceActionBlocker, CRITICAL_SPACE_THRESHOLD), Line 68: mockConfig(ConfigValues.WarningLowSpaceIndicator, LOW_SPACE_THRESHOLD) Line 69: ); These changes are redundant - the test suite passes without them. Line 70: Line 71: protected static final org.ovirt.engine.core.common.businessentities.StorageDomainType TYPES_MAPPED[] = { Line 72: org.ovirt.engine.core.common.businessentities.StorageDomainType.Data, Line 73: org.ovirt.engine.core.common.businessentities.StorageDomainType.ISO, -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
