Lior Vernia has posted comments on this change. Change subject: engine: Allow empty Host Network QoS override ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/37431/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 271: if (networkName == null) { Line 272: continue; Line 273: } Line 274: Line 275: if (iface.isQosOverridden() && !iface.getQos().isEmpty()) { > Please check iface.getQos() != null Done. Also changed the shape of the code a little - the first error should be displayed regardless of empty QoS. Line 276: if (!hostNetworkQosSupported) { Line 277: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NETWORK_QOS_NOT_SUPPORTED, networkName); Line 278: } Line 279: -- To view, visit https://gerrit.ovirt.org/37431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddd2738a2db0666a07c6db9db23d4fe4572816f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
