Daniel Erez has posted comments on this change. Change subject: core: update CinderDisks connections on RunVm ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39656/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java: Line 282: for (CinderDisk cinderDisk : cinderDisks) { Line 283: try { Line 284: CinderBroker cinderBroker = new CinderBroker(cinderDisk.getStorageIds().get(0), getReturnValue().getExecuteFailedMessages()); Line 285: CinderConnectionInfo connectionInfo = cinderBroker.initializeConnectionForDisk(cinderDisk); Line 286: if (CinderVolumeDriver.forValue(connectionInfo.getDriverVolumeType()) == null) { > I think this should be validated before in the CDA phase it's a bit problematic for a couple of reasons: 1. moving this to the CDA means that we'll execute a request to Cinder on canDo (which is better to avoid). 2. we probably shouldn't block running a VM just because a problem with one disk (in case that other disks connections are valid...) Line 287: addCustomValue("DiskAlias", cinderDisk.getDiskAlias()); Line 288: auditLogDirector.log(this, AuditLogType.CINDER_DISK_CONNECTION_VOLUME_DRIVER_UNSUPPORTED); Line 289: return false; Line 290: } -- To view, visit https://gerrit.ovirt.org/39656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie48e01acd6c3afcbc322603e0358b63e2b2bdf99 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
