Yaniv Bronhaim has posted comments on this change. Change subject: monitor: implement NUMA aware KSM policy ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/40130/2/mom/Collectors/HostKSM.py File mom/Collectors/HostKSM.py: Line 113: file.seek(0) Line 114: data['ksm_' + datum] = parse_int('(.*)', file.read()) Line 115: data['ksm_shareable'] = self.get_shareable_mem() Line 116: data['ksmd_cpu_usage'] = self.get_ksmd_cpu_usage() Line 117: # self.log.debug("HostKSM.collect.data[ksm_merge_across_nodes] = %s", data['ksm_merge_across_nodes']) remove.. Line 118: return data Line 119: Line 120: def getFields(self=None): Line 121: f = lambda x: 'ksm_' + x https://gerrit.ovirt.org/#/c/40130/2/mom/Controllers/KSM.py File mom/Controllers/KSM.py: Line 22: - ksm_run - Change the state of the KSM kernel daemon: Line 23: 0 - Stop, 1 - Run, 2 - unmerge shared pages Line 24: - ksm_pages_to_scan - Set the number of pages to be scanned per work unit Line 25: - ksm_sleep_millisecs - Set the time to sleep between scans Line 26: - ksm_merge_across_nodes - Toggle (0/1), default 1, trailing whitespace Line 27: merge across all nodes = 1, merge inside each NUMA node = 0 Line 28: """ Line 29: def __init__(self, properties): Line 30: self.hypervisor_iface = properties['hypervisor_iface'] Line 28: """ Line 29: def __init__(self, properties): Line 30: self.hypervisor_iface = properties['hypervisor_iface'] Line 31: self.logger = logging.getLogger('mom.Controllers.KSM') Line 32: self.cur = { 'run': '0', 'pages_to_scan': '0', 'sleep_millisecs': '0', 'merge_across_nodes': '8'} pass the 80 chars in line Line 33: self.logger.debug("KSM policy initialized") Line 34: Line 35: def write_value(self, fname, value): Line 36: try: https://gerrit.ovirt.org/#/c/40130/2/mom/Entity.py File mom/Entity.py: Line 32: self.variables = {} Line 33: self.statistics = [] Line 34: self.controls = {} Line 35: self.monitor = monitor Line 36: self.logger = logging.getLogger('mom.Entity') do you really need it if you comment out all the prints? Line 37: Line 38: def _set_property(self, name, val): Line 39: self.properties[name] = val Line 40: -- To view, visit https://gerrit.ovirt.org/40130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26caf0abe0a33a82b242549ba2ba4ad7f01ec925 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
