Alon Bar-Lev has posted comments on this change. Change subject: webadmin,engine : allow user to set tuned profile ......................................................................
Patch Set 8: -Code-Review (1 comment) I always remember stuff after I +1... :( https://gerrit.ovirt.org/#/c/39769/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 486: _parser.cliEnvironmentSet( Line 487: TuneEnv.TUNED_PROFILE, Line 488: vdsGroup.getGlusterTunedProfile() Line 489: ); Line 490: } oh... you must send something... if you do not want to do anything please execute: _parser.cliNoop(); please make sure you actually test this. Line 491: } Line 492: return true; Line 493: }}, Line 494: new Callable<Boolean>() { public Boolean call() throws Exception { -- To view, visit https://gerrit.ovirt.org/39769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef3f957dfcc40cef8de541898fbc08d698d0ce7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
