Vered Volansky has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/35277/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java: Line 137: Integer availableSize = getAvailableDiskSize(); Line 138: return availableSize != null ? availableSize * SizeConverter.BYTES_IN_GB : null; Line 139: } Line 140: Line 141: public Integer getLowSpaceThreshold() { > This should be a primitive int - symmetrically to setLowSpaceThreshold Done Line 142: return staticData.getLowSpaceThreshold(); Line 143: } Line 144: Line 145: public void setLowSpaceThreshold(int lowSpaceThreshold) { Line 145: public void setLowSpaceThreshold(int lowSpaceThreshold) { Line 146: staticData.setLowSpaceThreshold(lowSpaceThreshold); Line 147: } Line 148: Line 149: public Integer getCriticalSpaceThreshold() { > Same here Done Line 150: return staticData.getCriticalSpaceThreshold(); Line 151: } Line 152: Line 153: public void setCriticalSpaceThreshold(int criticalSpaceThreshold) { -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
