Allon Mureinik has posted comments on this change. Change subject: restapi: Show full Gluster storage domain details ......................................................................
Patch Set 4: Code-Review+2 (1 comment) The storage logic here is sound. Acking based on Juan's +1 which I assume pretains to the REST-API correctness. https://gerrit.ovirt.org/#/c/39810/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java: Line 290: model.setMountOptions(entity.getMountOptions()); Line 291: } Line 292: } Line 293: else if (entity.getstorage_type().equals(org.ovirt.engine.core.common.businessentities.storage.StorageType.POSIXFS) Line 294: || entity.getstorage_type().equals(org.ovirt.engine.core.common.businessentities.storage.StorageType.GLUSTERFS)) { This method is disgusting. It should be re-written, but not in the scope of this patch. Line 295: model.setMountOptions(entity.getMountOptions()); Line 296: model.setVfsType(entity.getVfsType()); Line 297: } Line 298: return model; -- To view, visit https://gerrit.ovirt.org/39810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2294ab6a0256f5c8bc5f48e04dada506500f79d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
