Moti Asayag has posted comments on this change. Change subject: core: Add JPA Java infrastructure ......................................................................
Patch Set 60: (3 comments) i have a couple of minor comments, overall looks good to me. https://gerrit.ovirt.org/#/c/33835/60/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateTemplate.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateTemplate.java: Line 130: return entities; Line 131: } Line 132: Line 133: protected T singleResultNativeQuery(String sql) { Line 134: Query query = please merge lines Line 135: em.createNativeQuery(sql, type); Line 136: Line 137: return singleResult(query); Line 138: } Line 137: return singleResult(query); Line 138: } Line 139: Line 140: protected List<T> multiResultsNativeQuery(String sql) { Line 141: Query query = same Line 142: em.createNativeQuery(sql, type); Line 143: Line 144: return multiResults(query); Line 145: } https://gerrit.ovirt.org/#/c/33835/60/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/package-info.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/package-info.java: Line 6: package org.ovirt.engine.core.dao; Line 7: Line 8: import org.hibernate.annotations.TypeDef; Line 9: import org.hibernate.annotations.TypeDefs; Line 10: import org.ovirt.engine.core.compat.Guid;import org.ovirt.engine.core.dao.jpa.GuidUserType; please break into 2 lines -- To view, visit https://gerrit.ovirt.org/33835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b Gerrit-PatchSet: 60 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
