Daniel Erez has posted comments on this change. Change subject: core: adding ExtendCinderDisk command and callback ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/39199/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommand.java: Line 68: CinderDisk cinderDisk = (CinderDisk) getNewDisk(); Line 69: return cinderDisk.getStorageIds().get(0); Line 70: } Line 71: Line 72: protected long getNewDiskSizeInGB() { > Remove this method, it is already being removed in another patch Done Line 73: CinderDisk cinderDisk = (CinderDisk) getNewDisk(); Line 74: return cinderDisk.getSize() / (1024 * 1024 * 1024); Line 75: } Line 76: https://gerrit.ovirt.org/#/c/39199/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommandCallback.java: Line 35: @Override Line 36: public void onFailed(Guid cmdId, List<Guid> childCmdIds) { Line 37: super.onFailed(cmdId, childCmdIds); Line 38: Line 39: getCommand().unlockImageInDb(); > Why calling this unlock, it should already been done in getCommand().endAct Done Line 40: log.error("Failed extending disk. ID: {}", getDiskId()); Line 41: updateAuditLog(AuditLogType.USER_EXTEND_DISK_SIZE_FAILURE, getCommand().getNewDiskSizeInGB()); Line 42: Line 43: getCommand().endAction(); -- To view, visit https://gerrit.ovirt.org/39199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03e0b6993d52f27f6241aeb7ad9a8b01326883d0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
