Sandro Bonazzola has posted comments on this change. Change subject: vdsm: gluster: provide 3.7 nightly builds ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39139/1/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 133: --repofrompath=check-patternfly-$distid,"${COPR}/patternfly/patternfly1/epel-${DISTRIBUTION_VERSION}-x86_64" \ Line 134: --lookaside check-updates-$distid \ Line 135: --lookaside check-extras-$distid \ Line 136: --lookaside check-epel-$distid \ Line 137: --lookaside check-glusterfs-epel-$distid-nightly \ > also, quoting all $variables everywhere is the prudent thing to do (in any Done Line 138: --lookaside check-glusterfs-epel-$distid \ Line 139: --lookaside check-glusterfs-noarch-epel-$distid \ Line 140: --lookaside check-base-$distid \ Line 141: --lookaside check-base-i386-$ditsid \ Line 133: --repofrompath=check-patternfly-$distid,"${COPR}/patternfly/patternfly1/epel-${DISTRIBUTION_VERSION}-x86_64" \ Line 134: --lookaside check-updates-$distid \ Line 135: --lookaside check-extras-$distid \ Line 136: --lookaside check-epel-$distid \ Line 137: --lookaside check-glusterfs-epel-$distid-nightly \ > It's nicer if you use ${distid}-nightly, to avoid thinking that $distid-nig Done Line 138: --lookaside check-glusterfs-epel-$distid \ Line 139: --lookaside check-glusterfs-noarch-epel-$distid \ Line 140: --lookaside check-base-$distid \ Line 141: --lookaside check-base-i386-$ditsid \ -- To view, visit https://gerrit.ovirt.org/39139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c56659eb2e768695c6f22f92f44f19587921fae Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
