Ori Liel has posted comments on this change. Change subject: core: FenceVdsVDSCommand code cleanup ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38060/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java: Line 63: () Maybe redundant? You're providing 'Action' to fenceNode(); the method can check for itself if [action!=FenceActionType.STATUS] (no need to provide it as another parameter). Line 176: FenceActionType Continuation of the comment from above: could this method even be invoked with actionType!=Status, and "false"? I have a feeling we don't need a boolean in the signature -- To view, visit https://gerrit.ovirt.org/38060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I480f03acf41d53e90c3c0da6725523d0578adb52 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
