Piotr Kliczewski has posted comments on this change. Change subject: engine: Replace deprecated access to ResourceManager ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38524/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java: Line 69: /** Line 70: * Stops {@code VdsManager} for a host. Line 71: */ Line 72: public void stopConnection() { Line 73: resourceManager.RemoveVds(this.vds.getId()); Please use this which indicates that we are using instance field. It will prevent hard to find shadowing issues in the future. Line 74: } Line 75: Line 76: /** Line 77: * Fall back the protocol and attempts the connection {@link ProtocolDetector#attemptConnection()}. Line 79: * @return <code>true</code> if connected or <code>false</code> if connection failed. Line 80: */ Line 81: public boolean attemptFallbackProtocol() { Line 82: vds.setProtocol(VdsProtocol.XML); Line 83: resourceManager.AddVds(vds, false); As above Line 84: return attemptConnection(); Line 85: } Line 86: Line 87: /** -- To view, visit https://gerrit.ovirt.org/38524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie78fff7c5be5998bd9c769cbefa99317ac590b89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
